Idea

4
Replies
710
Views
LEE_FR Member since 2004 1 post
PEGA
Posted: December 6, 2017
Last activity: August 23, 2020

Enhancement suggestions for Code Reviews in Pega 7

I like the new branch/code review feature in Pega 7. However, after using this feature for a month +, I have noticed some anomalies that I feel product management should consider.

Issue 1
Code reviews happen in the context of a point in time, but the rules list in the review does not reflect this. For example -
I start and finish code review 1 on Monday where there are 3 rules. I add pulse comments to the rules
I create 2 more rules in the branch on Tuesday
I start and finish code review 2 on Tuesday and there are 5 rules but I don't see pulse comments from Monday's review
I go back to Monday's code review and I find my older comments BUT I see the new rules I've added Tuesday (future)
This causes confusion because review 1 is closed and it makes it *appear* that we've reviewed the newer rules which is not the case.
Possible Solutions - when the review is closed, consider doing a historical snapshot where the rules in the review are "frozen" OR add a flag that clearly states the newer rules were added AFTER the review was closed.

Issue 2
Deleting the branch also deletes the rules list in the code review - you can still find and open the branch review work object, but the rules list in the review are gone and the pulse comments are not accessible - this behavior feels like a major flaw
Possible Solutions - deleting the branch should not clear the rules list in the review

Issue 3
Not deleting the branch keeps the rules list in the code review for historical audit however then you get all sorts of branch merge warnings because you haven't deleted the branch - so, if we want to keep the historical audit trail, we then have branch warnings on future merges on the same rule -
Possible Solutions - deleting the branch should not clear the rules list in the review

SR Exists
Share this page LinkedIn